lib/ogsf: fix possible overflow errors in gvld.c #4637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing `(255 << 24)` which causes integer overflow and positive number gets converted to negative number. We were then assigning this to an unsigned integer in multiple places, which does conversion in a different way. For example: If we do unsigned int x = -20, `UINT_MAX + 1 - 20` is assigned to x. I do not think that's what is intended when we do `ktrans = (255 << 24)`. Fix instances of that, by using an unsigned int literal over int literal. This issue was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
ymdatta
changed the title
nilason
changed the title
nilason
approved these changes
Nov 5, 2024
Merged
a0x8o
pushed a commit
to a0x8o/grass
that referenced
this pull request
Nov 11, 2024
ogsf: fix possible overflow errors in gvld module We were doing `(255 << 24)` which causes integer overflow and positive number gets converted to negative number. We were then assigning this to an unsigned integer in multiple places, which does conversion in a different way. For example: If we do unsigned int x = -20, `UINT_MAX + 1 - 20` is assigned to x. I do not think that's what is intended when we do `ktrans = (255 << 24)`. Fix instances of that, by using an unsigned int literal over int literal. This issue was found using cppcheck tool. Signed-off-by: Mohan Yelugoti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #4635.
We were doing
(255 << 24)which causes integer overflow and positive number gets converted to negative number. We were then assigning this to an unsigned integer in multiple places, which does conversion in a different way.For example: If we do unsigned int x = -20,
UINT_MAX + 1 - 20is assigned to x.I do not think that's what is intended when we do
ktrans = (255 << 24). Fix instances of that, by using an unsigned int literal over int literal.This issue was found using cppcheck tool.